From 14ff832c58835b5dbde3a20a7c76ba20838642dc Mon Sep 17 00:00:00 2001
From: Rodrigo Rodriguez <rodriguez@pragmatismo.cloud>
Date: Sat, 25 May 2024 10:08:39 -0300
Subject: [PATCH] new(all): Azure OpenAI added as new LLM provider.

---
 packages/admin.gbapp/dialogs/AdminDialog.ts             | 2 +-
 packages/core.gbapp/services/GBConversationalService.ts | 4 ++--
 packages/core.gbapp/services/GBCoreService.ts           | 2 +-
 packages/core.gbapp/services/GBImporterService.ts       | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/packages/admin.gbapp/dialogs/AdminDialog.ts b/packages/admin.gbapp/dialogs/AdminDialog.ts
index 8c2606bf..c396e864 100644
--- a/packages/admin.gbapp/dialogs/AdminDialog.ts
+++ b/packages/admin.gbapp/dialogs/AdminDialog.ts
@@ -288,7 +288,7 @@ export class AdminDialog extends IGBDialog {
 
           const packages = [];
           let skipError = false;
-          if (filename === null || filename === '') {
+          if (!filename || filename === '') {
             await min.conversationalService.sendText(min, step, `Starting publishing for ${botId} packages...`);
             packages.push(`${botId}.gbot`);
             packages.push(`${botId}.gbtheme`);
diff --git a/packages/core.gbapp/services/GBConversationalService.ts b/packages/core.gbapp/services/GBConversationalService.ts
index 5490e492..4c2494d8 100644
--- a/packages/core.gbapp/services/GBConversationalService.ts
+++ b/packages/core.gbapp/services/GBConversationalService.ts
@@ -868,7 +868,7 @@ export class GBConversationalService {
   }
 
   public async routeNLP(step: GBDialogStep, min: GBMinInstance, text: string) {
-    if (min.instance.nlpAppId === null || min.instance.nlpAppId === undefined) {
+    if (!min.instance.nlpAppId) {
       return false;
     }
 
@@ -1013,7 +1013,7 @@ export class GBConversationalService {
     const key = min.core.getParam<string>(min.instance, 'translatorKey', null);
 
     if (
-      (endPoint === null && !min.instance.googleProjectId) ||
+      (!endPoint && !min.instance.googleProjectId) ||
       !translatorEnabled() ||
       process.env.TRANSLATOR_DISABLED === 'true'
     ) {
diff --git a/packages/core.gbapp/services/GBCoreService.ts b/packages/core.gbapp/services/GBCoreService.ts
index 0a1760e7..14b53e73 100644
--- a/packages/core.gbapp/services/GBCoreService.ts
+++ b/packages/core.gbapp/services/GBCoreService.ts
@@ -737,7 +737,7 @@ ENDPOINT_UPDATE=true
     if (params && !value) {
       value = instance['dataValues'][name];
       const minBoot = GBServer.globals.minBoot as any;
-      if (value === null && instance != minBoot.instance) {
+      if (!value  && instance != minBoot.instance) {
         params = GBUtil.caseInsensitive(minBoot.instance.dataValues);
         value = params[name];
 
diff --git a/packages/core.gbapp/services/GBImporterService.ts b/packages/core.gbapp/services/GBImporterService.ts
index 374ef447..a29e6cda 100644
--- a/packages/core.gbapp/services/GBImporterService.ts
+++ b/packages/core.gbapp/services/GBImporterService.ts
@@ -95,7 +95,7 @@ export class GBImporter {
       instance = await this.core.loadInstanceByBotId(botId);
     }
 
-    if (instance != undefined && instance.botId === null) {
+    if (instance != undefined && !instance.botId) {
       console.log(`Null BotId after load instance with botId: ${botId}.`);
     } else {
       instance = additionalInstance;