From 1bbb94d5006cab39ac0eb0f05088763615373230 Mon Sep 17 00:00:00 2001
From: "Rodrigo Rodriguez (Pragmatismo)" <me@rodrigorodriguez.com>
Date: Sun, 1 Mar 2026 10:17:30 -0300
Subject: [PATCH] fix(directory): improve error message for invalid credentials

- Updated error message to explain when credentials are found but invalid
- Clarified that credentials might be from a previous installation
- Added step-by-step solution for resetting credentials
- Removed misleading 'No admin credentials found' message

The error now accurately reflects the actual problem: authentication
failure rather than missing credentials.
---
 src/core/package_manager/mod.rs | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/src/core/package_manager/mod.rs b/src/core/package_manager/mod.rs
index cd47f1f61..5f353ed7f 100644
--- a/src/core/package_manager/mod.rs
+++ b/src/core/package_manager/mod.rs
@@ -196,21 +196,26 @@ async fn get_admin_credentials(stack_path: &str) -> anyhow::Result<AdminCredenti
         return Ok(AdminCredentials { email, password });
     }
 
-    // Approach 3: Error with helpful message
+    // This should not be reached - initialize() will handle authentication errors
+    // If we get here, it means credentials were found but authentication failed
     log::error!("═══════════════════════════════════════════════════════════════");
-    log::error!("❌ FAILED TO GET ZITADEL ADMIN CREDENTIALS");
+    log::error!("❌ ZITADEL AUTHENTICATION FAILED");
     log::error!("═══════════════════════════════════════════════════════════════");
-    log::error!("Could not find credentials in:");
-    log::error!("  - ~/.gb-setup-credentials");
-    log::error!("  - {}/logs/directory/zitadel.log", stack_path);
+    log::error!("Credentials were found but authentication failed.");
+    log::error!("This usually means:");
+    log::error!("  • Credentials are from a previous Zitadel installation");
+    log::error!("  • User account is locked or disabled");
+    log::error!("  • Password has been changed");
     log::error!("");
-    log::error!("SOLUTION: Run a fresh bootstrap to create initial admin user:");
-    log::error!("  1. Delete .env and botserver-stack/conf/system/.bootstrap_completed");
-    log::error!("  2. Run: ./reset.sh");
-    log::error!("  3. Admin credentials will be displayed and saved");
+    log::error!("SOLUTION: Reset and create fresh credentials:");
+    log::error!("  1. Delete: rm ~/.gb-setup-credentials");
+    log::error!("  2. Delete: rm .env");
+    log::error!("  3. Delete: rm botserver-stack/conf/system/.bootstrap_completed");
+    log::error!("  4. Run: ./reset.sh");
+    log::error!("  5. New admin credentials will be displayed and saved");
     log::error!("═══════════════════════════════════════════════════════════════");
 
-    anyhow::bail!("No admin credentials found. Run fresh bootstrap to create them.")
+    anyhow::bail!("Authentication failed. Reset bootstrap to create fresh credentials.")
 }
 
 /// Read credentials from ~/.gb-setup-credentials file