From c1c6d56ab5374895d57959ce2ae2cfe576761354 Mon Sep 17 00:00:00 2001 From: arenasio <39930591+arenasio@users.noreply.github.com> Date: Sat, 16 Feb 2019 17:15:40 -0200 Subject: [PATCH 1/4] Update README.md --- README.md | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/README.md b/README.md index 52dfdfe0..003682d2 100644 --- a/README.md +++ b/README.md @@ -138,16 +138,13 @@ Note: 2. Install [git](`https://git-scm.com/`), a Software Configuration Management (SCM).; 3. Install [Node.js](npmjs.com/get-npm), a [Runtime system](https://en.wikipedia.org/wiki/Runtime_system). (https://www.npmjs.com/get-npm) (suggested: LTS 8.x.x); -4. Install [Visual Studio Code](https://chocolatey.org/packages/nodejs.install), Brackets or Atom as an editor of your choice; -5. [Fork](https://en.wikipedia.org/wiki/Fork_(software_development)) by visiting https://github.com/pragmatismo-io/BotServer/fork -6. Clone the just forked repository by running `git clone /BotServer.git` ; -7. Run `npm install -g typescript`; -8. Run `npm install` on Command Prompt or PowerShell on the General Bot source-code folder; -9. Enter './packages/default.gbui' folder; -10. Run `npm install` folled by `npm run build` (To build default Bot UI); -11. Enter the On the downloaded folder (../..); -12. Compile the bot server by `tsc`. -13. Run the bot server by `npm start`. +4. Install npm install -g npm-check-updates; +5. Install [Visual Studio Code](https://chocolatey.org/packages/nodejs.install), Brackets or Atom as an editor of your choice; +6. [Fork](https://en.wikipedia.org/wiki/Fork_(software_development)) by visiting https://github.com/pragmatismo-io/BotServer/fork +7. Clone the just forked repository by running `git clone /BotServer.git` ; +8. Run `npm install -g typescript`; +9. Compile the bot server by `tsc`. +10. Run the bot server by `npm start`. Note: From 4b2087856281647c0c73d8ba8b599185a085a9ce Mon Sep 17 00:00:00 2001 From: Rafael Arenario Pereira da Silva Date: Sat, 23 Feb 2019 18:20:21 -0300 Subject: [PATCH 2/4] chore(core.gbapp): Improving error message for NPL. --- packages/core.gbapp/services/GBConversationalService.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core.gbapp/services/GBConversationalService.ts b/packages/core.gbapp/services/GBConversationalService.ts index d062353a..30d84b6b 100644 --- a/packages/core.gbapp/services/GBConversationalService.ts +++ b/packages/core.gbapp/services/GBConversationalService.ts @@ -104,7 +104,7 @@ export class GBConversationalService implements IGBConversationalService { nlp = await model.recognize(step.context); } catch (error) { if (error.statusCode === 404) { - logger.warn('NLP application still not publish and there are no other options for answering.'); + logger.warn('NLP application still not publish and there are no other options for answering, please associate the key on NLP portal.'); return Promise.resolve(false); } else { From e21916f35e4e2fadaf332f54ebaf971ab62dd109 Mon Sep 17 00:00:00 2001 From: Rodrigo Rodriguez Date: Wed, 1 May 2019 08:48:30 -0300 Subject: [PATCH 3/4] fix(kb.gbapp): Fix in subjects null pointer. --- .vscode/tasks.json | 19 +++++++++++++++++++ packages/analytics.gblib/models/index.ts | 1 - .../services/AzureDeployerService.ts | 2 +- packages/kb.gbapp/services/KBService.ts | 3 ++- packages/security.gblib/models/index.ts | 1 - 5 files changed, 22 insertions(+), 4 deletions(-) create mode 100644 .vscode/tasks.json diff --git a/.vscode/tasks.json b/.vscode/tasks.json new file mode 100644 index 00000000..e402cbb0 --- /dev/null +++ b/.vscode/tasks.json @@ -0,0 +1,19 @@ +{ + // See https://go.microsoft.com/fwlink/?LinkId=733558 + // for the documentation about the tasks.json format + "version": "2.0.0", + "tasks": [ + { + "type": "typescript", + "tsconfig": "tsconfig.json", + "option": "watch", + "problemMatcher": [ + "$tsc-watch" + ], + "group": { + "kind": "build", + "isDefault": true + } + } + ] +} \ No newline at end of file diff --git a/packages/analytics.gblib/models/index.ts b/packages/analytics.gblib/models/index.ts index f0f494f3..6d0fc6e5 100644 --- a/packages/analytics.gblib/models/index.ts +++ b/packages/analytics.gblib/models/index.ts @@ -36,7 +36,6 @@ 'use strict'; - import { AutoIncrement, BelongsTo, diff --git a/packages/azuredeployer.gbapp/services/AzureDeployerService.ts b/packages/azuredeployer.gbapp/services/AzureDeployerService.ts index 383af961..fe436d54 100644 --- a/packages/azuredeployer.gbapp/services/AzureDeployerService.ts +++ b/packages/azuredeployer.gbapp/services/AzureDeployerService.ts @@ -486,7 +486,7 @@ export class AzureDeployerService implements IGBInstallationDeployer { } catch (error) { reject(error); } - }, 20000); + }, 60000); }); } diff --git a/packages/kb.gbapp/services/KBService.ts b/packages/kb.gbapp/services/KBService.ts index 11029b48..87a4de37 100644 --- a/packages/kb.gbapp/services/KBService.ts +++ b/packages/kb.gbapp/services/KBService.ts @@ -86,6 +86,7 @@ export class KBService { public static getSubjectItemsSeparatedBySpaces(subjects: GuaribasSubject[]) { const out = []; + if (subjects === undefined) { return ''; } subjects.forEach(subject => { out.push(subject.internalId); }); @@ -168,7 +169,7 @@ export class KBService { query = `${query} ${text}`; } } - query = `${query}&$filter=instanceId eq ${instance.instanceId}`; + // TODO: query = `${query}&$filter=instanceId eq ${instance.instanceId}`; // tslint:disable:no-unsafe-any if (instance.searchKey !== null && GBConfigService.get('STORAGE_DIALECT') === 'mssql') { diff --git a/packages/security.gblib/models/index.ts b/packages/security.gblib/models/index.ts index 215be291..2cb49ce8 100644 --- a/packages/security.gblib/models/index.ts +++ b/packages/security.gblib/models/index.ts @@ -36,7 +36,6 @@ 'use strict'; - import { AutoIncrement, BelongsTo, From c697ead53a7027ec82245101c5ccceba0fc560ae Mon Sep 17 00:00:00 2001 From: Arenasio Date: Wed, 1 May 2019 13:14:36 +0000 Subject: [PATCH 4/4] Fix(core.gbapp): Fixing nlp typo --- packages/core.gbapp/services/GBConversationalService.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core.gbapp/services/GBConversationalService.ts b/packages/core.gbapp/services/GBConversationalService.ts index 68024e3c..b3bf8ec7 100644 --- a/packages/core.gbapp/services/GBConversationalService.ts +++ b/packages/core.gbapp/services/GBConversationalService.ts @@ -141,7 +141,7 @@ export class GBConversationalService implements IGBConversationalService { GBLog.info(`NLP called: ${intent} ${firstEntity}`); try { - await step.replaceDialog(` /${intent}`, nlp.entities); + await step.replaceDialog(`/${intent}`, nlp.entities); return Promise.resolve(true); } catch (error) {