From 36a9a8eb1d78ef55777a168231ad418b45319d5a Mon Sep 17 00:00:00 2001
From: Rodrigo Rodriguez <me@rodrigorodriguez.com>
Date: Sat, 16 Mar 2024 23:06:15 -0300
Subject: [PATCH] new(security.gblib): SMS Auth.

---
 .../services/GBConversationalService.ts       | 33 ++++++++++---------
 1 file changed, 18 insertions(+), 15 deletions(-)

diff --git a/packages/core.gbapp/services/GBConversationalService.ts b/packages/core.gbapp/services/GBConversationalService.ts
index 5c95a8fa..f3804409 100644
--- a/packages/core.gbapp/services/GBConversationalService.ts
+++ b/packages/core.gbapp/services/GBConversationalService.ts
@@ -354,23 +354,26 @@ export class GBConversationalService {
 
   // tslint:disable:no-unsafe-any due to Nexmo.
   public async sendSms(min: GBMinInstance, mobile: string, text: string): Promise<any> {
-    let botNumber = process.env.BOT_NUMBER;
-
-    GBLog.info(`Sending SMS from ${botNumber} to ${mobile} with text: '${text}'.`);
-    const accountSid = process.env.TWILIO_ACCOUNT_SID;
-    const authToken = process.env.TWILIO_AUTH_TOKEN;
-    const client = twilio(null, authToken, { accountSid: accountSid });
+    
+    let botNumber = min.core.getParam<string>(min.instance, 'Bot Number', null);
+    if (botNumber) {
 
 
-    const msg = await client.messages
-      .create({
-        body: text,
-        from: '+' + botNumber,
-        to: '+' + mobile
-      })
+      GBLog.info(`Sending SMS from ${botNumber} to ${mobile} with text: '${text}'.`);
+      const accountSid = process.env.TWILIO_ACCOUNT_SID;
+      const authToken = process.env.TWILIO_AUTH_TOKEN;
+      const client = twilio(null, authToken, { accountSid: accountSid });
 
-    GBLogEx.info(min, `SMS sent, return: ${msg.sid}.`);
 
+      const msg = await client.messages
+        .create({
+          body: text,
+          from: '+' + botNumber,
+          to: '+' + mobile
+        })
+
+      GBLogEx.info(min, `SMS sent, return: ${msg.sid}.`);
+    }
     return;
 
     if (!min.instance.smsKey && min.instance.smsSecret) {
@@ -423,8 +426,8 @@ export class GBConversationalService {
 
   public async sendToMobile(min: GBMinInstance, mobile: string, message: string, conversationId) {
     GBLog.info(`Sending message ${message} to ${mobile}...`);
-    return min.whatsAppDirectLine ? await min.whatsAppDirectLine.sendToDevice(mobile, message, conversationId):
-    await this.sendSms(min, mobile, message);
+    return min.whatsAppDirectLine ? await min.whatsAppDirectLine.sendToDevice(mobile, message, conversationId) :
+      await this.sendSms(min, mobile, message);
   }
 
   public static async getAudioBufferFromText(text): Promise<string> {