From 5ed835afdb356cfbd078c70be41d41470b2cb655 Mon Sep 17 00:00:00 2001 From: Rodrigo Rodriguez Date: Thu, 18 Jan 2024 09:41:17 -0300 Subject: [PATCH] new(basic.gblib): API online for GB. --- packages/azuredeployer.gbapp/services/AzureDeployerService.ts | 1 - packages/core.gbapp/services/GBConversationalService.ts | 2 +- src/app.ts | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/azuredeployer.gbapp/services/AzureDeployerService.ts b/packages/azuredeployer.gbapp/services/AzureDeployerService.ts index 7c936047..2a125df5 100644 --- a/packages/azuredeployer.gbapp/services/AzureDeployerService.ts +++ b/packages/azuredeployer.gbapp/services/AzureDeployerService.ts @@ -108,7 +108,6 @@ export class AzureDeployerService implements IGBInstallationDeployer { public static async createInstanceWithCredentials(deployer: GBDeployer, freeTier: boolean = true, subscriptionId: string, username: string, password: string): Promise { - const service = new AzureDeployerService(); const credentials = await GBAdminService.getADALCredentialsFromUsername(username, password); return await this.createInstanceWithADALCredentials(deployer, freeTier, subscriptionId, credentials); } diff --git a/packages/core.gbapp/services/GBConversationalService.ts b/packages/core.gbapp/services/GBConversationalService.ts index d907cabe..ce07f725 100644 --- a/packages/core.gbapp/services/GBConversationalService.ts +++ b/packages/core.gbapp/services/GBConversationalService.ts @@ -1002,7 +1002,7 @@ export class GBConversationalService { const keepText: string = min.core.getParam(min.instance, 'Keep Text', ''); let keepTextList = []; - if (keepTextList) { + if (keepTextList && keepText) { keepTextList = keepTextList.concat(keepText.split(';')); } const replacements = []; diff --git a/src/app.ts b/src/app.ts index 6835684b..0eed208d 100644 --- a/src/app.ts +++ b/src/app.ts @@ -139,7 +139,6 @@ export class GBServer { const core: IGBCoreService = new GBCoreService(); const importer: GBImporter = new GBImporter(core); const deployer: GBDeployer = new GBDeployer(core, importer); - const subscriptionId = GBConfigService.get('CLOUD_SUBSCRIPTIONID'); let azureDeployer: AzureDeployerService; // Ensure that local proxy is setup.