From 946a66b692e33b344d526fa3840e63fdcf4c2ca3 Mon Sep 17 00:00:00 2001
From: Rodrigo Rodriguez <me@rodrigorodriguez.com>
Date: Mon, 9 Mar 2020 14:19:17 -0300
Subject: [PATCH] fix(core.gbapp): Custom boot dialog only available to boot
 bot.

---
 packages/core.gbapp/dialogs/WelcomeDialog.ts  |  3 +-
 packages/core.gbapp/services/GBDeployer.ts    |  1 -
 .../services/SharePointService.ts             | 29 ++-----------------
 3 files changed, 4 insertions(+), 29 deletions(-)

diff --git a/packages/core.gbapp/dialogs/WelcomeDialog.ts b/packages/core.gbapp/dialogs/WelcomeDialog.ts
index 2b130c76..8e7c983c 100644
--- a/packages/core.gbapp/dialogs/WelcomeDialog.ts
+++ b/packages/core.gbapp/dialogs/WelcomeDialog.ts
@@ -57,7 +57,8 @@ export class WelcomeDialog extends IGBDialog {
     min.dialogs.add(new WaterfallDialog('/', [
       async step => {
 
-        if (GBServer.globals.entryPointDialog !== null)
+        if (GBServer.globals.entryPointDialog !== null &&
+          min.instance.botId === process.env.BOT_ID)
         {
           return step.replaceDialog(GBServer.globals.entryPointDialog);
         }
diff --git a/packages/core.gbapp/services/GBDeployer.ts b/packages/core.gbapp/services/GBDeployer.ts
index 36179916..47e38ef6 100644
--- a/packages/core.gbapp/services/GBDeployer.ts
+++ b/packages/core.gbapp/services/GBDeployer.ts
@@ -178,7 +178,6 @@ export class GBDeployer {
     instance.adminPass = GBAdminService.getRndPassword();
     instance.title = botId;
 
-
     await this.core.saveInstance(instance);
 
     return await this.deployBotFull(instance, GBServer.globals.publicAddress);
diff --git a/packages/sharepoint.gblib/services/SharePointService.ts b/packages/sharepoint.gblib/services/SharePointService.ts
index 1dfd97ef..1ace8ffa 100644
--- a/packages/sharepoint.gblib/services/SharePointService.ts
+++ b/packages/sharepoint.gblib/services/SharePointService.ts
@@ -36,32 +36,7 @@
 
 'use strict';
 
-import { HttpHeaders, HttpMethods, ServiceClient, WebResource } from '@azure/ms-rest-js';
-import { CognitiveServicesManagementClient } from 'azure-arm-cognitiveservices';
-import { ResourceManagementClient, SubscriptionClient } from 'azure-arm-resource';
-import { SearchManagementClient } from 'azure-arm-search';
-import { SqlManagementClient } from 'azure-arm-sql';
-import { WebSiteManagementClient } from 'azure-arm-website';
-//tslint:disable-next-line:no-submodule-imports
-import { AppServicePlan, Site, SiteConfigResource, SiteLogsConfig, SiteSourceControl } from 'azure-arm-website/lib/models';
-import { GBLog, IGBInstallationDeployer, IGBInstance } from 'botlib';
-import { GBAdminService } from '../../admin.gbapp/services/GBAdminService';
-import { GBCorePackage } from '../../core.gbapp';
-import { GBConfigService } from '../../core.gbapp/services/GBConfigService';
-import { GBDeployer } from '../../core.gbapp/services/GBDeployer';
-const MicrosoftGraph = require("@microsoft/microsoft-graph-client");
-
-const Spinner = require('cli-spinner').Spinner;
-// tslint:disable-next-line: no-submodule-imports
-import * as simplegit from 'simple-git/promise';
-const git = simplegit();
-
-// tslint:disable-next-line:no-submodule-imports
-import { CognitiveServicesAccount } from 'azure-arm-cognitiveservices/lib/models';
-import urlJoin = require('url-join');
-const iconUrl = 'https://github.com/pragmatismo-io/BotServer/blob/master/docs/images/generalbots-logo-squared.png';
-const publicIp = require('public-ip');
-const WebSiteResponseTimeout = 900;
+const { sppull } = require("sppull");
 
 /**
  * Service facade for SharePoint Online.
@@ -69,7 +44,6 @@ const WebSiteResponseTimeout = 900;
 export class GBSharePointService {
 
     public async downloadFolder(localPath: string, siteUrl: string, folderUrl: string, username: string, password: string) {
-        const { sppull } = require("sppull");
 
         const context = {
             siteUrl: siteUrl,
@@ -87,4 +61,5 @@ export class GBSharePointService {
         return await sppull(context, options);
     }
 
+
 }