From c600a91cde10acbe553197df167d7181f681f7bf Mon Sep 17 00:00:00 2001
From: Rodrigo Rodriguez <me@rodrigorodriguez.com>
Date: Tue, 14 Sep 2021 15:10:46 -0300
Subject: [PATCH] fix(core.gbapp): Fix main NLP problem in Y calls.

---
 .../core.gbapp/services/GBConversationalService.ts   | 12 +++++++-----
 packages/core.gbapp/services/GBMinService.ts         |  1 -
 packages/kb.gbapp/dialogs/AskDialog.ts               |  5 +++--
 3 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/packages/core.gbapp/services/GBConversationalService.ts b/packages/core.gbapp/services/GBConversationalService.ts
index 7405b497..3ce55113 100644
--- a/packages/core.gbapp/services/GBConversationalService.ts
+++ b/packages/core.gbapp/services/GBConversationalService.ts
@@ -626,7 +626,11 @@ export class GBConversationalService {
     }
   }
 
-  public async routeNLP(step: GBDialogStep, min: GBMinInstance, text: string): Promise<boolean> {
+  // TODO: Update botlib.
+  public async routeNLP(step: GBDialogStep, min: GBMinInstance, text: string): Promise<Boolean> {
+    return false;
+  }
+  public async routeNLP2(step: GBDialogStep, min: GBMinInstance, text: string) {
     if (min.instance.nlpAppId === null || min.instance.nlpAppId === undefined) {
       return false;
     }
@@ -713,16 +717,14 @@ export class GBConversationalService {
         });
       }
 
-      await step.replaceDialog(`/${intent}`, step.activeDialog.state.options);
-
-      return true;
+      return await step.replaceDialog(`/${intent}`, step.activeDialog.state.options);
     }
 
     GBLog.info(
       `NLP NOT called: score: ${score} > required (nlpScore): ${instanceScore}`
     );
 
-    return false;
+    return null;
   }
 
   public async getLanguage(min: GBMinInstance, text: string): Promise<string> {
diff --git a/packages/core.gbapp/services/GBMinService.ts b/packages/core.gbapp/services/GBMinService.ts
index bae373e2..3062c598 100644
--- a/packages/core.gbapp/services/GBMinService.ts
+++ b/packages/core.gbapp/services/GBMinService.ts
@@ -1242,7 +1242,6 @@ export class GBMinService {
 
         if (step.activeDialog !== undefined) {
           await step.continueDialog();
-
         } else {
 
           const startDialog = user.hearOnDialog ?
diff --git a/packages/kb.gbapp/dialogs/AskDialog.ts b/packages/kb.gbapp/dialogs/AskDialog.ts
index c6d3a400..e114facd 100644
--- a/packages/kb.gbapp/dialogs/AskDialog.ts
+++ b/packages/kb.gbapp/dialogs/AskDialog.ts
@@ -256,8 +256,9 @@ export class AskDialog extends IGBDialog {
 
         // Tries to answer by NLP.
 
-        if (await min.conversationalService.routeNLP(step, min, text)) {
-          return await step.replaceDialog('/ask', { isReturning: true });
+        let nextDialog = await min.conversationalService["routeNLP2"](step, min, text);
+        if (nextDialog) {
+          return nextDialog;
         }
 
         // Tries to answer by Reading Comprehension.