From ed374c26c8a67ac9f0f3959cce9741b2bb30f316 Mon Sep 17 00:00:00 2001 From: Rodrigo Rodriguez Date: Mon, 4 Sep 2023 16:10:08 -0300 Subject: [PATCH] fix(all): Fix in bot proxy outdated columns. --- packages/admin.gbapp/dialogs/AdminDialog.ts | 2 +- .../azuredeployer.gbapp/services/AzureDeployerService.ts | 2 +- packages/core.gbapp/services/GBMinService.ts | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/admin.gbapp/dialogs/AdminDialog.ts b/packages/admin.gbapp/dialogs/AdminDialog.ts index e567e4daa..0422987ac 100644 --- a/packages/admin.gbapp/dialogs/AdminDialog.ts +++ b/packages/admin.gbapp/dialogs/AdminDialog.ts @@ -421,7 +421,7 @@ export class AdminDialog extends IGBDialog { min.adminService.setValue(min.instance.instanceId, 'AntiCSRFAttackState', state); - const redirectUri = urlJoin(min.instance.botEndpoint, min.instance.botId, '/token'); + const redirectUri = urlJoin(process.env.BOT_URL, min.instance.botId, '/token'); const url = `https://login.microsoftonline.com/${step.activeDialog.state.authenticatorTenant}/oauth2/authorize?client_id=${min.instance.marketplaceId}&response_type=code&redirect_uri=${redirectUri}&scope=https://graph.microsoft.com/.default&state=${state}&response_mode=query`; await min.conversationalService.sendText(min, step, Messages[locale].consent(url)); diff --git a/packages/azuredeployer.gbapp/services/AzureDeployerService.ts b/packages/azuredeployer.gbapp/services/AzureDeployerService.ts index d14963ce2..b69f86c83 100644 --- a/packages/azuredeployer.gbapp/services/AzureDeployerService.ts +++ b/packages/azuredeployer.gbapp/services/AzureDeployerService.ts @@ -455,7 +455,7 @@ export class AzureDeployerService implements IGBInstallationDeployer { }; GBLog.info(`Deploying Bot...`); - instance.botEndpoint = this.defaultEndPoint; + instance.botEndpoint = 'TODO: remove this column.'; instance = await this.internalDeployBot( instance, diff --git a/packages/core.gbapp/services/GBMinService.ts b/packages/core.gbapp/services/GBMinService.ts index b4e5f9602..028dc3d5e 100644 --- a/packages/core.gbapp/services/GBMinService.ts +++ b/packages/core.gbapp/services/GBMinService.ts @@ -542,7 +542,7 @@ export class GBMinService { authenticationContext.acquireTokenWithAuthorizationCode( req.query.code, - urlJoin(instance.botEndpoint, min.instance.botId, '/token'), + urlJoin(process.env.BOT_URL, min.instance.botId, '/token'), resource, instance.marketplaceId, instance.marketplacePassword, @@ -561,7 +561,7 @@ export class GBMinService { // Inform the home for default .gbui after finishing token retrival. - res.redirect(min.instance.botEndpoint); + res.redirect(process.env.BOT_URL); } } ); @@ -581,7 +581,7 @@ export class GBMinService { ); authorizationUrl = `${authorizationUrl}?response_type=code&client_id=${ min.instance.marketplaceId - }&redirect_uri=${urlJoin(min.instance.botEndpoint, min.instance.botId, 'token')}`; + }&redirect_uri=${urlJoin(process.env.BOT_URL, min.instance.botId, 'token')}`; GBLog.info(`HandleOAuthRequests: ${authorizationUrl}.`); res.redirect(authorizationUrl); });