- Fix match arms with identical bodies by consolidating patterns - Fix case-insensitive file extension comparisons using eq_ignore_ascii_case - Fix unnecessary Debug formatting in log/format macros - Fix clone_from usage instead of clone assignment - Fix let...else patterns where appropriate - Fix format! append to String using write! macro - Fix unwrap_or with function calls to use unwrap_or_else - Add missing fields to manual Debug implementations - Fix duplicate code in if blocks - Add type aliases for complex types - Rename struct fields to avoid common prefixes - Various other clippy warning fixes Note: Some 'unused async' warnings remain for functions that are called with .await but don't contain await internally - these are kept async for API compatibility.
326 lines
9.6 KiB
Rust
326 lines
9.6 KiB
Rust
use crate::shared::models::UserSession;
|
|
use crate::shared::state::AppState;
|
|
use log::{error, trace};
|
|
use rhai::{Dynamic, Engine};
|
|
use serde_json::json;
|
|
use std::sync::Arc;
|
|
|
|
#[derive(Debug, Clone)]
|
|
pub enum SuggestionType {
|
|
Context(String),
|
|
|
|
Tool {
|
|
name: String,
|
|
params: Option<Vec<String>>,
|
|
},
|
|
}
|
|
|
|
pub fn clear_suggestions_keyword(
|
|
state: Arc<AppState>,
|
|
user_session: UserSession,
|
|
engine: &mut Engine,
|
|
) {
|
|
let cache = state.cache.clone();
|
|
|
|
engine
|
|
.register_custom_syntax(["CLEAR", "SUGGESTIONS"], true, move |_context, _inputs| {
|
|
if let Some(cache_client) = &cache {
|
|
let redis_key = format!("suggestions:{}:{}", user_session.user_id, user_session.id);
|
|
let mut conn = match cache_client.get_connection() {
|
|
Ok(conn) => conn,
|
|
Err(e) => {
|
|
error!("Failed to connect to cache: {}", e);
|
|
return Ok(Dynamic::UNIT);
|
|
}
|
|
};
|
|
|
|
let result: Result<i64, redis::RedisError> =
|
|
redis::cmd("DEL").arg(&redis_key).query(&mut conn);
|
|
|
|
match result {
|
|
Ok(deleted) => {
|
|
trace!(
|
|
"Cleared {} suggestions from session {}",
|
|
deleted,
|
|
user_session.id
|
|
);
|
|
}
|
|
Err(e) => error!("Failed to clear suggestions from Redis: {}", e),
|
|
}
|
|
} else {
|
|
trace!("No cache configured, suggestions not cleared");
|
|
}
|
|
|
|
Ok(Dynamic::UNIT)
|
|
})
|
|
.unwrap();
|
|
}
|
|
|
|
pub fn add_suggestion_keyword(
|
|
state: Arc<AppState>,
|
|
user_session: UserSession,
|
|
engine: &mut Engine,
|
|
) {
|
|
let cache = state.cache.clone();
|
|
let cache2 = state.cache.clone();
|
|
let cache3 = state.cache.clone();
|
|
let user_session2 = user_session.clone();
|
|
let user_session3 = user_session.clone();
|
|
|
|
engine
|
|
.register_custom_syntax(
|
|
["ADD", "SUGGESTION", "$expr$", "AS", "$expr$"],
|
|
true,
|
|
move |context, inputs| {
|
|
let context_name = context.eval_expression_tree(&inputs[0])?.to_string();
|
|
let button_text = context.eval_expression_tree(&inputs[1])?.to_string();
|
|
|
|
add_context_suggestion(cache.as_ref(), &user_session, &context_name, &button_text)?;
|
|
|
|
Ok(Dynamic::UNIT)
|
|
},
|
|
)
|
|
.unwrap();
|
|
|
|
engine
|
|
.register_custom_syntax(
|
|
["ADD", "SUGGESTION", "TOOL", "$expr$", "AS", "$expr$"],
|
|
true,
|
|
move |context, inputs| {
|
|
let tool_name = context.eval_expression_tree(&inputs[0])?.to_string();
|
|
let button_text = context.eval_expression_tree(&inputs[1])?.to_string();
|
|
|
|
add_tool_suggestion(
|
|
cache2.as_ref(),
|
|
&user_session2,
|
|
&tool_name,
|
|
None,
|
|
&button_text,
|
|
)?;
|
|
|
|
Ok(Dynamic::UNIT)
|
|
},
|
|
)
|
|
.unwrap();
|
|
|
|
engine
|
|
.register_custom_syntax(
|
|
[
|
|
"ADD",
|
|
"SUGGESTION",
|
|
"TOOL",
|
|
"$expr$",
|
|
"WITH",
|
|
"$expr$",
|
|
"AS",
|
|
"$expr$",
|
|
],
|
|
true,
|
|
move |context, inputs| {
|
|
let tool_name = context.eval_expression_tree(&inputs[0])?.to_string();
|
|
let params_value = context.eval_expression_tree(&inputs[1])?;
|
|
let button_text = context.eval_expression_tree(&inputs[2])?.to_string();
|
|
|
|
let params = if params_value.is_array() {
|
|
params_value
|
|
.cast::<rhai::Array>()
|
|
.iter()
|
|
.map(|v| v.to_string())
|
|
.collect()
|
|
} else {
|
|
params_value
|
|
.to_string()
|
|
.split(',')
|
|
.map(|s| s.trim().to_string())
|
|
.collect()
|
|
};
|
|
|
|
add_tool_suggestion(
|
|
cache3.as_ref(),
|
|
&user_session3,
|
|
&tool_name,
|
|
Some(params),
|
|
&button_text,
|
|
)?;
|
|
|
|
Ok(Dynamic::UNIT)
|
|
},
|
|
)
|
|
.unwrap();
|
|
}
|
|
|
|
fn add_context_suggestion(
|
|
cache: Option<&Arc<redis::Client>>,
|
|
user_session: &UserSession,
|
|
context_name: &str,
|
|
button_text: &str,
|
|
) -> Result<(), Box<rhai::EvalAltResult>> {
|
|
if let Some(cache_client) = cache {
|
|
let redis_key = format!("suggestions:{}:{}", user_session.user_id, user_session.id);
|
|
|
|
let suggestion = json!({
|
|
"type": "context",
|
|
"context": context_name,
|
|
"text": button_text,
|
|
"action": {
|
|
"type": "select_context",
|
|
"context": context_name
|
|
}
|
|
});
|
|
|
|
let mut conn = match cache_client.get_connection() {
|
|
Ok(conn) => conn,
|
|
Err(e) => {
|
|
error!("Failed to connect to cache: {}", e);
|
|
return Ok(());
|
|
}
|
|
};
|
|
|
|
let result: Result<i64, redis::RedisError> = redis::cmd("RPUSH")
|
|
.arg(&redis_key)
|
|
.arg(suggestion.to_string())
|
|
.query(&mut conn);
|
|
|
|
match result {
|
|
Ok(length) => {
|
|
trace!(
|
|
"Added context suggestion '{}' to session {}, total: {}",
|
|
context_name,
|
|
user_session.id,
|
|
length
|
|
);
|
|
|
|
let active_key = format!(
|
|
"active_context:{}:{}",
|
|
user_session.user_id, user_session.id
|
|
);
|
|
|
|
let _: Result<i64, redis::RedisError> = redis::cmd("HSET")
|
|
.arg(&active_key)
|
|
.arg(context_name)
|
|
.arg("inactive")
|
|
.query(&mut conn);
|
|
}
|
|
Err(e) => error!("Failed to add suggestion to Redis: {}", e),
|
|
}
|
|
} else {
|
|
trace!("No cache configured, suggestion not added");
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
fn add_tool_suggestion(
|
|
cache: Option<&Arc<redis::Client>>,
|
|
user_session: &UserSession,
|
|
tool_name: &str,
|
|
params: Option<Vec<String>>,
|
|
button_text: &str,
|
|
) -> Result<(), Box<rhai::EvalAltResult>> {
|
|
if let Some(cache_client) = cache {
|
|
let redis_key = format!("suggestions:{}:{}", user_session.user_id, user_session.id);
|
|
|
|
let suggestion = json!({
|
|
"type": "tool",
|
|
"tool": tool_name,
|
|
"text": button_text,
|
|
"action": {
|
|
"type": "invoke_tool",
|
|
"tool": tool_name,
|
|
"params": params,
|
|
|
|
|
|
"prompt_for_params": params.is_none()
|
|
}
|
|
});
|
|
|
|
let mut conn = match cache_client.get_connection() {
|
|
Ok(conn) => conn,
|
|
Err(e) => {
|
|
error!("Failed to connect to cache: {}", e);
|
|
return Ok(());
|
|
}
|
|
};
|
|
|
|
let result: Result<i64, redis::RedisError> = redis::cmd("RPUSH")
|
|
.arg(&redis_key)
|
|
.arg(suggestion.to_string())
|
|
.query(&mut conn);
|
|
|
|
match result {
|
|
Ok(length) => {
|
|
trace!(
|
|
"Added tool suggestion '{}' to session {}, total: {}, has_params: {}",
|
|
tool_name,
|
|
user_session.id,
|
|
length,
|
|
params.is_some()
|
|
);
|
|
}
|
|
Err(e) => error!("Failed to add tool suggestion to Redis: {}", e),
|
|
}
|
|
} else {
|
|
trace!("No cache configured, tool suggestion not added");
|
|
}
|
|
|
|
Ok(())
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use serde_json::json;
|
|
|
|
#[test]
|
|
fn test_suggestion_json_context() {
|
|
let suggestion = json!({
|
|
"type": "context",
|
|
"context": "products",
|
|
"text": "View Products",
|
|
"action": {
|
|
"type": "select_context",
|
|
"context": "products"
|
|
}
|
|
});
|
|
|
|
assert_eq!(suggestion["type"], "context");
|
|
assert_eq!(suggestion["action"]["type"], "select_context");
|
|
}
|
|
|
|
#[test]
|
|
fn test_suggestion_json_tool_no_params() {
|
|
let suggestion = json!({
|
|
"type": "tool",
|
|
"tool": "search_kb",
|
|
"text": "Search Knowledge Base",
|
|
"action": {
|
|
"type": "invoke_tool",
|
|
"tool": "search_kb",
|
|
"params": Option::<Vec<String>>::None,
|
|
"prompt_for_params": true
|
|
}
|
|
});
|
|
|
|
assert_eq!(suggestion["type"], "tool");
|
|
assert_eq!(suggestion["action"]["prompt_for_params"], true);
|
|
}
|
|
|
|
#[test]
|
|
fn test_suggestion_json_tool_with_params() {
|
|
let params = vec!["query".to_string(), "products".to_string()];
|
|
let suggestion = json!({
|
|
"type": "tool",
|
|
"tool": "search_kb",
|
|
"text": "Search Products",
|
|
"action": {
|
|
"type": "invoke_tool",
|
|
"tool": "search_kb",
|
|
"params": params,
|
|
"prompt_for_params": false
|
|
}
|
|
});
|
|
|
|
assert_eq!(suggestion["type"], "tool");
|
|
assert_eq!(suggestion["action"]["prompt_for_params"], false);
|
|
assert!(suggestion["action"]["params"].is_array());
|
|
}
|
|
}
|